Dynamics GP – Copy address button using VBA & Modifier

Introduction - why add a copy button?

Dynamics GP Sales Order Processing (SOP) allows orders to be placed against debtors (customers). For each customer you can have any number of addresses stored, this address book can then be used by sales staff when an order is placed to avoid rekeying the information.

We needed to start storing an address per contact as the contact’s name is captured within the address block. Some delivery sites for national organisations are huge, many thousands of people are fed from one central goods in delivery point. This means that each contact email address is essentially the same bar for the contact name.

Requirement

To speed up order entry and address capture and accuracy, a requirement was identified to allow SOP users to copy a master address for these larger site. This would then merely require sales to add a contact name to the account master template address they copy, rather than manually copying and pasting the address each time.

Add a copy button & combo box to address windows

Using Microsoft Dynamics Modifier, select the address entry screens for GP. You might choose

DebtorAddressMaintenance & SalesShipToAddressEntry, for example. If you use 3rd party dictionaries, watch for alternatives to these in those dictionaries.

Drop a new button onto each form, rename the button btnCopy for this example.
Drop a drop down combobox to the form, name it ddlAddress

Modified GP Dynamics Address Form

When the form is loaded with data, the combobox will be filled with the list of address ID’s available for this customer. By default the default address ID will select itself, and the selected address ID will be used as the source for the copy address function. The copy address functionality will be invoked by the pressing of the btnCopy.

Save the modified form, if you do not currently have permissions set up for the modified form, please ensure your sers are pointed by security at the new form.

VBA behind the form

Now it must be remembered to add the window and fields to VBA that were created. Those are the button and the combobox, also needed is to add the customer number field and each of the address fields that are to be copied to VBA.

For this article I will assume we are working with the DebtorAddressMaintenance window. For this window when a new debtor number is entered, then the combobox that was added must be populated with the available AddressID’s for that customer. The combobox is also required to default to the customer address ID selected in the main customer maintenance card as the default ship address.

SQL

We must query the Dynamics GP database for all the address IDs for this customer stored in the “address book”.

ALTER PROCEDURE [yourschema].[SOP_GetCustomerAddressCodes]
   @CUSTNMBR  varchar(15)
AS
BEGIN
    SET NOCOUNT ON;
    SELECT     RM00102.ADRSCODE, ISNULL(RM00101.PRSTADCD,'') 
        as SHIPPINGADRSCODE
    FROM RM00102
    LEFT JOIN 
         RM00101 
    ON RM00102.CUSTNMBR=RM00101.CUSTNMBR
    WHERE  
      (RM00102.CUSTNMBR = @CUSTNMBR) 
  
END
 

And to get a specific address

 

ALTER PROCEDURE [yourschema].[SOP_GetCustomerAddress]
   @CUSTNMBR  varchar(15),
   @ADRSCODE  varchar(15)    
AS
BEGIN
    SET NOCOUNT ON;
    SELECT CUSTNMBR, ADRSCODE, SLPRSNID, UPSZONE, SHIPMTHD,
           TAXSCHID, CNTCPRSN, ADDRESS1, ADDRESS2, ADDRESS3, COUNTRY, CITY, STATE, 
           ZIP, PHONE1, PHONE2, PHONE3, FAX, MODIFDT, CREATDDT, GPSFOINTEGRATIONID,
           INTEGRATIONSOURCE, INTEGRATIONID, CCode, DECLID, 
           LOCNCODE, SALSTERR, USERDEF1, USERDEF2, DEX_ROW_ID
    FROM   RM00102
    WHERE  (CUSTNMBR = @CUSTNMBR) 
       AND (ADRSCODE = @ADRSCODE)
 
END

Address Class

A class called clsSOPAddress is made in the class modules section of your VBA project as follows;

Option Explicit
Private m_CustomerNumber As String
Private m_AddressID As String
Private m_Contact As String
Private m_Address1 As String
Private m_Address2 As String
Private m_Address3 As String
Private m_City As String
Private m_County As String
Private m_PostCode As String
Private m_CountryCode As String
Private m_Country As String
Private m_Phone1 As String
Private m_Phone2 As String
Private m_Phone3 As String
Private m_Fax As String
Private m_CarrierZone As String
Private m_ShippingMethod As String
Private m_TaxScheduleID As String
Private m_SiteID As String
Private m_SalesPersonID As String
Private m_TerritoryID As String
Private m_UserDefined1 As String
Private m_UserDefined2 As String



Public Property Let CustomerNumber(CustNumber As String)
m_CustomerNumber = CustNumber
End Property
Public Property Get CustomerNumber() As String
CustomerNumber = m_CustomerNumber
End Property

Public Property Let AddressID(Adrid As String)
m_AddressID = Adrid
End Property
Public Property Get AddressID() As String
AddressID = m_AddressID
End Property

Public Property Get Contact() As String
Contact = m_Contact
End Property
Public Property Get Address1() As String
Address1 = m_Address1
End Property
Public Property Get Address2() As String
Address2 = m_Address2
End Property
Public Property Get Address3() As String
Address3 = m_Address3
End Property
Public Property Get City() As String
City = m_City
End Property
Public Property Get County() As String
County = m_County
End Property
Public Property Get Postcode() As String
Postcode = m_PostCode
End Property
Public Property Get CountryCode() As String
CountryCode = m_CountryCode
End Property
Public Property Get Country() As String
Country = m_Country
End Property
Public Property Get Phone1() As String
Phone1 = m_Phone1
End Property
Public Property Get Phone2() As String
Phone2 = m_Phone2
End Property
Public Property Get Phone3() As String
Phone3 = m_Phone3
End Property
Public Property Get Fax() As String
Fax = m_Fax
End Property
Public Property Get CarrierZone() As String
CarrierZone = m_CarrierZone
End Property
Public Property Get ShippingMethod() As String
ShippingMethod = m_ShippingMethod
End Property
Public Property Get TaxScheduleID() As String
TaxScheduleID = m_TaxScheduleID
End Property
Public Property Get SiteID() As String
SiteID = m_SiteID
End Property
Public Property Get SalespersonID() As String
SalespersonID = m_SalesPersonID
End Property
Public Property Get TerritoryID() As String
TerritoryID = m_TerritoryID
End Property
Public Property Get UserDefined1() As String
UserDefined1 = m_UserDefined1
End Property
Public Property Get UserDefined2() As String
UserDefined2 = m_UserDefined2
End Property

Public Sub LoadAddress()
On Error GoTo ErrorHandler
Dim SQLRec As New ADODB.Recordset 'holds recordset SQL

Dim Cmd1 As ADODB.Command
Set Cmd1 = New ADODB.Command

Dim SQLCon As ADODB.Connection
Set SQLCon = New ADODB.Connection

If SQLCon.State <> adStateOpen Then SQLCon.Open Microsoft_Dynamics_GP.GetConnectionStr
Cmd1.ActiveConnection = SQLCon
Cmd1.CommandText = "SOP_GetCustomerAddress"
Cmd1.CommandType = adCmdStoredProc
Dim prm1 As New ADODB.Parameter
Dim prm2 As New ADODB.Parameter

Set prm1 = Cmd1.CreateParameter("@CUSTNMBR", adVarChar, adParamInput, 15, Trim(Me.CustomerNumber))
Set prm2 = Cmd1.CreateParameter("@SOPNUMBE", adVarChar, adParamInput, 15, Trim(Me.AddressID))
With Cmd1
.Parameters.Append prm1
.Parameters.Append prm2
End With

SQLRec.Open Cmd1.Execute
If Not SQLRec.BOF And Not SQLRec.EOF Then
m_Contact = Trim(SQLRec.Fields("CNTCPRSN").Value)
m_Address1 = Trim(SQLRec.Fields("ADDRESS1").Value)
m_Address2 = Trim(SQLRec.Fields("ADDRESS2").Value)
m_Address3 = Trim(SQLRec.Fields("ADDRESS3").Value)
m_City = Trim(SQLRec.Fields("CITY").Value)
m_County = Trim(SQLRec.Fields("STATE").Value)
m_PostCode = Trim(SQLRec.Fields("ZIP").Value)
m_Phone1 = Trim(SQLRec.Fields("PHONE1").Value)
m_Phone2 = Trim(SQLRec.Fields("PHONE2").Value)
m_Phone3 = Trim(SQLRec.Fields("PHONE3").Value)
m_Fax = Trim(SQLRec.Fields("FAX").Value)
m_CountryCode = Trim(SQLRec.Fields("CCODE").Value)
m_Country = Trim(SQLRec.Fields("COUNTRY").Value)
m_CarrierZone = Trim(SQLRec.Fields("UPSZONE").Value)
m_ShippingMethod = Trim(SQLRec.Fields("SHIPMTHD").Value)
m_TaxScheduleID = Trim(SQLRec.Fields("TAXSCHID").Value)
m_SiteID = Trim(SQLRec.Fields("LOCNCODE").Value)
m_SalesPersonID = Trim(SQLRec.Fields("SLPRSNID").Value)
m_TerritoryID = Trim(SQLRec.Fields("SALSTERR").Value)
m_UserDefined1 = Trim(SQLRec.Fields("USERDEF1").Value)
m_UserDefined2 = Trim(SQLRec.Fields("USERDEF2").Value)


Else
'Address not found...
End If


'Close database connection and clean up
If CBool(SQLRec.State And adStateOpen) = True Then SQLRec.Close
Set SQLRec = Nothing

If CBool(SQLCon.State And adStateOpen) = True Then SQLCon.Close
Set SQLCon = Nothing

Set prm1 = Nothing
Set prm2 = Nothing
Set Cmd1 = Nothing

'Break before error hander
Exit Sub
ErrorHandler:
MsgBox "VBA Error trying to get address" + vbCrLf _
& vbCrLf & Err.Description, vbCritical + vbOKOnly, "Error in get address"
End Sub

Public Function GetAvailableAddressCodes() As String()
On Error GoTo ErrorHandler
Dim Results() As String
ReDim Results(0 To 0)
Dim SQLRec As New ADODB.Recordset 'holds recordset SQL

Dim Cmd1 As ADODB.Command
Set Cmd1 = New ADODB.Command

Dim SQLCon As ADODB.Connection
Set SQLCon = New ADODB.Connection

If SQLCon.State <> adStateOpen Then SQLCon.Open Microsoft_Dynamics_GP.GetConnectionStr
Cmd1.ActiveConnection = SQLCon
Cmd1.CommandText = "SOP_GetCustomerAddressCodes"
Cmd1.CommandType = adCmdStoredProc
Dim prm1 As New ADODB.Parameter

Set prm1 = Cmd1.CreateParameter("@CUSTNMBR", adVarChar, adParamInput, 15, Trim(Me.CustomerNumber))
With Cmd1
.Parameters.Append prm1
End With

SQLRec.Open Cmd1.Execute

Dim RecordCount As Integer
RecordCount = 0

Do While Not SQLRec.EOF

ReDim Preserve Results(RecordCount)
If SQLRec.Fields("ADRSCODE").Value = SQLRec.Fields("SHIPPINGADRSCODE").Value Then
Results(RecordCount) = "%" & SQLRec.Fields("ADRSCODE").Value
Else
Results(RecordCount) = SQLRec.Fields("ADRSCODE").Value
End If

RecordCount = RecordCount + 1
SQLRec.MoveNext
Loop

'Close database connection and clean up
If CBool(SQLRec.State And adStateOpen) = True Then SQLRec.Close
Set SQLRec = Nothing

If CBool(SQLCon.State And adStateOpen) = True Then SQLCon.Close
Set SQLCon = Nothing

Set prm1 = Nothing
Set Cmd1 = Nothing
GetAvailableAddressCodes = Results
'Break before error hander
Exit Function
ErrorHandler:
MsgBox "VBA Error trying to get address" + vbCrLf _
& vbCrLf & Err.Description, vbCritical + vbOKOnly, "Error in get address"
End Function

This class will handle fetching of the addresses. The default address is marked by a % that allows the combo box to by default select the address that contains that symbol and use it as default selection.

Now introduce a new module, utils, in the VBA project, into it add the following function for getting the list of addresses;

Public Function GetAddresses(DebtorID As String) As String()
On Error GoTo ErrorHandler

Dim osopAddress As New clsSOPAddress
osopAddress.CustomerNumber = DebtorID
GetAddresses = osopAddress.GetAvailableAddressCodes
Exit Function
ErrorHandler:
MsgBox "VBA Error trying to get available address ids." + vbCrLf _
+ " " + vbCrLf _
& vbCrLf & Err.Description, vbCritical + vbOKOnly, _
"Error in GetAddress"
End Function

We can now call this function from our address form in order to fill our combobox, We do this by using a unsupported (but fully working) method of calling dex code from VBA. In this case we are running this form from a 3rd party credit control form, hence the referenced dictionary.

Private Sub DebtorID_Changed()
On Error GoTo ErrorHandler
Dim CompilerApp As Object
Dim CompilerMessage As String
Dim CompilerError As Integer
Dim CompilerCommand As String

Set CompilerApp = CreateObject("Dynamics.Application")
CompilerCommand = ""
CompilerCommand = CompilerCommand & _
"clear '(L) ddlAddresses' of window RM_Customer_Address of form RM_Customer_Address;"_
& vbCrLf

ReDim oAddressList(0 To 0) 'initialise to zero for ubound checking
If Not DebtorID.Empty Then
oAddressList = utils.GetAddresses(DebtorID.Value)
Dim currentIndex As Integer
Dim defaultIndex As Integer
defaultIndex = -1
For currentIndex = LBound(oAddressList) To UBound(oAddressList)
If Left(oAddressList(currentIndex), 1) = "%" Then
CompilerCommand = CompilerCommand & "add item "" " & _
Mid(oAddressList(currentIndex), 2) & """, " & CStr(currentIndex) & vbCrLf
defaultIndex = currentIndex
Else
CompilerCommand = CompilerCommand & "add item "" " & oAddressList(currentIndex) _
& """, " & CStr(currentIndex) & vbCrLf
End If
CompilerCommand = CompilerCommand &_
" to '(L) ddlAddresses' of window RM_Customer_Address of form RM_Customer_Address;" _
& vbCrLf
Next currentIndex
End If
If defaultIndex = -1 Then defaultIndex = 0
CompilerCommand = CompilerCommand & _
"'(L) ddlAddresses' of window RM_Customer_Address of form RM_Customer_Address = "_
& Str(defaultIndex + 1) & ";" & vbCrLf

' Execute SanScript
CompilerApp.CurrentProductID = 2422 ' Nolans Credit Control
CompilerApp.CurrentProduct = CompilerApp.CurrentProduct & "!Modified"
CompilerError = CompilerApp.ExecuteSanscript(CompilerCommand, CompilerMessage)
If CompilerError <> 0 Then
MsgBox CompilerMessage
End If
'exit sub before the error handling kicks in
Exit Sub
ErrorHandler:
MsgBox "An Error occured on debtorid change." + vbCrLf + "" & vbCrLf & Err.Description,_
vbCritical + vbOKOnly, "Error in DebtorID.Changed"
End Sub

Finally the copy itself

When the uses presses btncopy the address associated with the addresscode shown by the combobox is got and it is used to populate the form fields.

Private oAddressList() As String ' holds addresslist for lookup

Private Sub Copy_BeforeUserChanged(KeepFocus As Boolean, _
CancelLogic As Boolean)
On Error GoTo ErrorHandler
If Not DebtorID.Empty Then
Dim oAddress As clsSOPAddress
If Left(oAddressList(ddlAddresses.Value - 1), 1) = "%" Then
Set oAddress = utils.GetCustomerAddress(Me.DebtorID, _
Mid(oAddressList(ddlAddresses.Value - 1), 2))
Else
Set oAddress = utils.GetCustomerAddress(Me.DebtorID, _
oAddressList(ddlAddresses.Value - 1))
End If

Contact.Value = oAddress.Contact
Address.Value = oAddress.Address1
Address1.Value = oAddress.Address2
Address2.Value = oAddress.Address3
City.Value = oAddress.City
County.Value = oAddress.County
Postcode.Value = oAddress.Postcode
Country.Value = oAddress.Country
CountryCode.Value = oAddress.CountryCode
Phone1.Value = oAddress.Phone1
Phone2.Value = oAddress.Phone2
Phone3.Value = oAddress.Phone3
Fax.Value = oAddress.Fax
CarrierZone.Value = oAddress.CarrierZone
ShippingMethod.Value = oAddress.ShippingMethod
TaxScheduleID.Value = oAddress.TaxScheduleID
SiteID.Value = oAddress.SiteID
SalespersonID.Value = oAddress.SalespersonID
TerritoryID.Value = oAddress.TerritoryID
UserDefined1.Value = oAddress.UserDefined1
End If
'exit sub before the error handling kicks in
Exit Sub

Entity framework learning curve

I have just started using the Entity Framework (EF) to create some quick winforms for our Dynamics GP modifications. However I’ve been bogged down by performance issues. Writing the data layer in datasets brings my performance back to what I expect again.
It is possible, even normal to use stored procedures to gain control again, but for these forms it seemed over the top of the use they get, and I just wanted a quick and dirty implantation for a quick win. The performance arguments for stored procedures are getting thinner and in our environment they create a maintenance burden. Don’t get me wrong, the use of stored procedures and views has many times got me out a hole in avoiding recompiling applications, instead just a tweaking of the procedure driving the application.

Update from investigations:
Entity Framework 4 should improve on generated SQL. The issue I experienced here is the unicode one listed on the ADO.NET team blog,  Provide mechanism for efficient queries on non-Unicode columns, this is issue 5 in the list.

In .NET 3.5, whenever a constant or a parameter was used in LINQ to Entities query, we treated it as being Unicode. As a result, when comparing a constant to a property stored in a non-unicode column on SQL Server, if there was an index on that column, it was not being used.

To address the issue, we now generate non-unicode constants and parameters when these are used in LINQ to Entities queries in comparisons with non-unicode columns.

Original problem EF generated SQL has wrong types

Table Defined

The table I am working with is defined like so;

 
/****** Object:  Table [dbo].[CA_PICKLSTMAST]    Script Date: 11/09/2010 10:16:17 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
SET ANSI_PADDING ON
GO
CREATE TABLE [dbo].[CA_PICKLSTMAST](
    [SOPTYPE] [smallint] NOT NULL,
    [SOPNUMBE] [char](21) NOT NULL,
    [LASTAMENDED] [datetime] NOT NULL,
    [VERSION] [smallint] NOT NULL,
    [VOID] [bit] NOT NULL,
    [ACTIVE] [bit] NOT NULL,
    [PRINTED] [bit] NOT NULL,
    [TIMEPRINTED] [datetime] NULL,
    [ORDERTIMESTAMP] [datetime] NOT NULL,
    [CUSTNAME] [char](65) NULL,
    [PICKVALUE] [numeric](19, 5) NULL,
    [SHIPMTHD] [char](15) NULL,
    [PICKCODE] [char](3) NULL,
    [DOCID] [char](15) NULL,
    [DEX_ROW_ID] [int] IDENTITY(1,1) NOT NULL,
 CONSTRAINT [PK_CA_PICKLSTMAST] PRIMARY KEY NONCLUSTERED 
(
    [DEX_ROW_ID] ASC
)WITH (PAD_INDEX  = OFF, STATISTICS_NORECOMPUTE  = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON, FILLFACTOR = 90) ON [PRIMARY]
) ON [PRIMARY]
GO
SET ANSI_PADDING OFF
GO
CREATE NONCLUSTERED INDEX [IX_CA_PICKLSTMAST] ON [dbo].[CA_PICKLSTMAST] 
(
    [SOPTYPE] ASC,
    [SOPNUMBE] ASC
)WITH (PAD_INDEX  = OFF, STATISTICS_NORECOMPUTE  = OFF, SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON, FILLFACTOR = 90) ON [PRIMARY]
GO
CREATE UNIQUE NONCLUSTERED INDEX [IX_CA_PICKLSTMAST_1] ON [dbo].[CA_PICKLSTMAST] 
(
    [SOPTYPE] ASC,
    [SOPNUMBE] ASC,
    [VERSION] ASC
)WITH (PAD_INDEX  = OFF, STATISTICS_NORECOMPUTE  = OFF, SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON, FILLFACTOR = 90) ON [PRIMARY]
GO
EXEC sys.sp_addextendedproperty @name=N'MS_Description', @value=N'Random Code to access this pick list' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'TABLE',@level1name=N'CA_PICKLSTMAST', @level2type=N'COLUMN',@level2name=N'PICKCODE'
GO
EXEC sys.sp_addextendedproperty @name=N'MS_Description', @value=N'DOCID of order' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'TABLE',@level1name=N'CA_PICKLSTMAST', @level2type=N'COLUMN',@level2name=N'DOCID'
GO
EXEC sys.sp_addextendedproperty @name=N'MS_Description', @value=N'Holds the master records for pick lists generated by vb.net canford application.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'TABLE',@level1name=N'CA_PICKLSTMAST'
GO
Linq

I want to select all the records that match a certain SOPTYPE and SOPNUMBE.

Dim QueryCA_PICKLSTMAST As ObjectQuery(Of CA_PICKLSTMAST) _
= CType((From results In oSalesOrderProcessingEnity.CA_PICKLSTMAST _
Where results.SOPNUMBE = Me.SopNumber And results.SOPTYPE = Me.SOPTYPE), _
ObjectQuery(Of CA_PICKLSTMAST))
CAPICKLSTMASTBindingSource.DataSource = QueryCA_PICKLSTMAST.Execute(MergeOption.NoTracking)

Where the params are defined as;
Private m_SopNumber As String
Public Property SopNumber() As String
Get
Return m_SopNumber
End Get
Set(ByVal value As String)
If m_SopNumber <> value Then
m_SopNumber = value
RefreshForm()
End If

End Set
End Property

Private m_SOPTYPE As Short = 2
Public Property SOPTYPE() As Short
Get
Return m_SOPTYPE
End Get
Set(ByVal value As Short)
m_SOPTYPE = value
End Set
End Property
 
Resulting TSQL executed against SQL server
Now using datasets I get TSQL like this;
exec sp_executesql 
N'SELECT SOPTYPE,
 SOPNUMBE, LASTAMENDED, VERSION, VOID, ACTIVE, 
 PRINTED, TIMEPRINTED, ORDERTIMESTAMP, CUSTNAME, 
 PICKVALUE, SHIPMTHD, PICKCODE, 
 DOCID, DEX_ROW_ID
FROM CA_PICKLSTMAST
WHERE 
SOPTYPE=@SOPTYPE AND SOPNUMBE=@SOPNUMBE',
N'@SOPTYPE smallint,@SOPNUMBE char(21)',
@SOPTYPE=2,
@SOPNUMBE='W36077               '
 

 

Just as I would get if crafted by hand, however EF creates the following;

exec sp_executesql N'SELECT 
[Extent1].[SOPTYPE] AS [SOPTYPE], 
[Extent1].[SOPNUMBE] AS [SOPNUMBE], 
[Extent1].[LASTAMENDED] AS [LASTAMENDED], 
[Extent1].[VERSION] AS [VERSION], 
[Extent1].[VOID] AS [VOID], 
[Extent1].[ACTIVE] AS [ACTIVE], 
[Extent1].[PRINTED] AS [PRINTED], 
[Extent1].[TIMEPRINTED] AS [TIMEPRINTED], 
[Extent1].[ORDERTIMESTAMP] AS [ORDERTIMESTAMP], 
[Extent1].[CUSTNAME] AS [CUSTNAME], 
[Extent1].[PICKVALUE] AS [PICKVALUE], 
[Extent1].[SHIPMTHD] AS [SHIPMTHD], 
[Extent1].[PICKCODE] AS [PICKCODE], 
[Extent1].[DOCID] AS [DOCID], 
[Extent1].[DEX_ROW_ID] AS [DEX_ROW_ID]
FROM [dbo].[CA_PICKLSTMAST] AS [Extent1]
WHERE 
([Extent1].[SOPNUMBE] = @p__linq__101) 
AND 
([Extent1].[SOPTYPE] = @p__linq__102)',
N'@p__linq__101 nvarchar(6),
@p__linq__102 smallint',
@p__linq__101=N'W36077',
@p__linq__102=2

 

Notice all the type conversion going on, this is what I guess is causing my issue, nvarchar(6), for example...

This then kills my query performance (I have many more of these running on the Winform, so the form becomes very sluggish.

Execution Plans compared

EF Query plan

Above is the entity framework query plan.

Dataset Query plan

Above is the dataset query plan, look at the execution times and the way the load have been moved from an index to costly joins.

Solution

 

Entity Framework 4 should improve on generated SQL. The issue I experienced here is the unicode one listed on the ADO.NET team blog,  Provide mechanism for efficient queries on non-Unicode columns, this is issue 5 in the list.

In .NET 3.5, whenever a constant or a parameter was used in LINQ to Entities query, we treated it as being Unicode. As a result, when comparing a constant to a property stored in a non-unicode column on SQL Server, if there was an index on that column, it was not being used.

To address the issue, we now generate non-unicode constants and parameters when these are used in LINQ to Entities queries in comparisons with non-unicode columns.

Off I go to try it out with EF4 CTP…

Crosstab Microsoft Dynamics GP price tables

Rows to columns for price breaks

No doubt your sales team want to go on the road with a human friendly version of your prices for the customers to read. It is possible to do this with a SQL table function to extract the prices from GP with price breaks. The following example assumes you know how many price breaks you have in your price lists and will result in output something like the following screen shot. These results may be squirted into excel with more columns as described by your business requirements.
Results of join with IV00101 showing description pulled in

Two key SQL server functions that many people I find are not familiar with but are vital for this kind of data manipulation are; “ROW_NUMBER()” and “PARTITION BY” , one way to learn is to dive in with an example.

GP Price Table

Natively the prices are held in the table IV00108 of your company database.

ITEMNMBR CURNCYID PRCLEVEL UOFM TOQTY FROMQTY UOMPRICE
WIRE100 Z-US$ RETAIL Foot 100 0.01 0.35
WIRE100 Z-US$ RETAIL Foot 999999999999.99 100.01 0.29
WIRE100 Z-US$ RETAIL Spool 999999999999.99 0.01 190
WIRE100 Z-US$ RETAIL Yard 999999999999.99 0.01 0.65
WIRE100 Z-US$ EXTPRCLVL Foot 999999999999.99 0.01 0
WIRE100 Z-US$ EXTPRCLVL Yard 999999999999.99 0.01 0
WIRE100 Z-US$ EXTPRCLVL Spool 999999999999.99 0.01 0

There is a row per “price point”. Each row contains, the item sku, Currency of the price list, price list name, unit of measure, quantity break range and price.

This is unreadable to humans once you get, say 15,000 products, five currencies and ten or so price levels. From experience, one company this solution is used with has 1,623,586 rows in the price table IV00108.

Table Partitioning

Firstly the rows are grouped together by the common factor each output row should be sharing. Each row in this example should have the same Item, Currency, Price Level and unit of measure. A row number is added for each successive row within this grouping;

SELECT 
ITEMNMBR,CURNCYID, PRCLEVEL, UOMPRICE, FROMQTY, UOFM, TOQTY, ROW_NUMBER()
OVER(PARTITION BY
ITEMNMBR,PRCLEVEL, CURNCYID, UOFM
ORDER BY toqty ASC) AS 'RowNumber'
FROM iv00108 (NOLOCK) WHERE itemnmbr='WIRE100'

The above TSQL partitions the returned rows from IV00108 by ITEMNMBR,PRCLEVEL, CURNCYID, UOFM, for each row in the group a row number is generated by ROW_NUMBER() see the following output example. For this example, there are two quanity break columns for the prices of the “foot” unit of measure.
These are breaks of; 0.01+ and 100+, resulting in row numbers one and two for this unit of measure.

ITEMNMBR CURNCYID PRCLEVEL UOMPRICE FROMQTY UOFM TOQTY RowNumber
WIRE100 Z-US$ EXTPRCLVL 0.00000 0.01000

Foot

999999999999.99 1
WIRE100 Z-US$ EXTPRCLVL 0.00000 0.01000

Spool

999999999999.99 1
WIRE100 Z-US$ EXTPRCLVL 0.00000 0.01000

Yard

999999999999.99 1
WIRE100 Z-US$ RETAIL 0.35000 0.01000

Foot

100 1
WIRE100 Z-US$ RETAIL 0.29000 100.01000

Foot

999999999999.99 2
WIRE100 Z-US$ RETAIL 190.00000 0.01000

Spool

999999999999.99 1
WIRE100 Z-US$ RETAIL 0.65000 0.01000

Yard

999999999999.99 1

 

Now that we have the RowNumber, this can act as the anchor field to crosstab the data with. It makes sense to wrap this query in a common table expression (CTE) to clean it up. The output from the below should be identical to that above.

WITH PriceTable 
(ITEMNMBR, CURNCYID, PRCLEVEL, UOMPRICE, FROMQTY,UOFM, TOQTY,[RowNumber]) AS
(SELECT ITEMNMBR,CURNCYID, PRCLEVEL, UOMPRICE, FROMQTY, UOFM, toqty, ROW_NUMBER()
OVER(PARTITION BY
ITEMNMBR,PRCLEVEL, CURNCYID,UOFM
ORDER BY TOQTY ASC) AS 'RowNumber'
FROM iv00108 (NOLOCK) where itemnmbr='WIRE100'
)
SELECT * FROM PriceTable

Crosstabbing the Common Table Expression

Now building on the select statement from the CTE, it is crosstabbed by using CASE statements as shown below. All that has changed between these two scripts is the select out of the CTE. The select is also add “+” to the price from column results as well as some NULL handling to make the presentation cleaner for Excel should it end up there. This is optional, it might be more appropriate for other uses to keep the results as numeric values and do that kind of processing in the reporting tool.

WITH PriceTable
(ITEMNMBR, CURNCYID, PRCLEVEL, UOMPRICE, FROMQTY,UOFM, TOQTY,[RowNumber]) AS
(SELECT ITEMNMBR,CURNCYID, PRCLEVEL, UOMPRICE, FROMQTY, UOFM, toqty, ROW_NUMBER()
OVER(PARTITION BY
ITEMNMBR,PRCLEVEL, CURNCYID,UOFM
ORDER BY TOQTY ASC) AS 'RowNumber'
FROM iv00108 (NOLOCK) where itemnmbr='WIRE100'
)

select itemnmbr,
isnull(max(case when PriceTable.[RowNumber] = 1 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break1
, max(case when PriceTable.[RowNumber] = 1 then
uomprice end) as Price1
, isnull(max(case when PriceTable.[RowNumber] = 2 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break2
, max(case when PriceTable.[RowNumber] = 2 then
uomprice end) as Price2
,isnull( max(case when PriceTable.[RowNumber] = 3 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break3
, max(case when PriceTable.[RowNumber] = 3 then
uomprice end) as Price3
,isnull( max(case when PriceTable.[RowNumber] = 4 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break4
, max(case when PriceTable.[RowNumber] = 4 then
uomprice end) as Price4
, isnull(max(case when PriceTable.[RowNumber] = 5 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break5
, max(case when PriceTable.[RowNumber] = 5 then
uomprice end) as Price5
, isnull(max(case when PriceTable.[RowNumber] = 6 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break6
, max(case when PriceTable.[RowNumber] = 6 then
uomprice end) as Price6
from PriceTable
group by itemnmbr, curncyid, prclevel, UOFM;

 
 
The above TSQL generates the following table, where the rows have been transformed into columns by TSQL, just as required.
itemnmbr Break1   Price1 Break2 Price2 Break3 Price3 Break4 Price4 Break5 Price5 Break6 Price6
WIRE100 0+ 0.00000   NULL   NULL   NULL   NULL   NULL
WIRE100 0+ 0.00000   NULL   NULL   NULL   NULL   NULL
WIRE100 0+ 0.00000   NULL   NULL   NULL   NULL   NULL
WIRE100 0+ 0.35000 100+ 0.29000   NULL   NULL   NULL   NULL
WIRE100 0+ 190.00000   NULL   NULL   NULL   NULL   NULL
WIRE100 0+ 0.65000   NULL   NULL   NULL   NULL   NULL

Table valued function


Great there we have it, price table partitioned and crosstabbed. Lets not stop there as this is much more useful as a table valued function. This is achieved by wrapping the above SQL as shown below. Here we have decided that the calling script should provide the currency, pricelist, item pattern and unit of measure to export. Your application may differ and not require the expensive type conversions.

CREATE function [dbo].[Extract_PricesCrosstabTable] (
@CURNCYID varchar(15),
@PRCLEVEL varchar(11),
@ITEMPATTERN nvarchar(31) = '%',
@UOFM varchar(9) = '%'
)
RETURNS @retTable TABLE
(
[ITEMNMBR] [varchar](31) primary key NOT NULL,
[BREAK1] [varchar](255) NOT NULL,
[PRICE1] [numeric](19, 5) NULL,
[BREAK2] [varchar](255) NOT NULL,
[PRICE2] [numeric](19, 5) NULL,
[BREAK3] [varchar](255) NOT NULL,
[PRICE3] [numeric](19, 5) NULL,
[BREAK4] [varchar](255) NOT NULL,
[PRICE4] [numeric](19, 5) NULL,
[BREAK5] [varchar](255) NOT NULL,
[PRICE5] [numeric](19, 5) NULL,
[BREAK6] [varchar](255) NOT NULL,
[PRICE6] [numeric](19, 5) NULL
)
AS
BEGIN

WITH PriceTable
(ITEMNMBR, CURNCYID, PRCLEVEL, UOMPRICE, FROMQTY,UOFM, TOQTY,[RowNumber]) AS
(SELECT ITEMNMBR,CURNCYID, PRCLEVEL, UOMPRICE, FROMQTY, UOFM, toqty, ROW_NUMBER()
OVER(PARTITION BY
ITEMNMBR,PRCLEVEL, CURNCYID,UOFM
ORDER BY TOQTY ASC) AS 'RowNumber'
FROM iv00108 (NOLOCK) where itemnmbr like @ITEMPATTERN and PRCLEVEL= @PRCLEVEL
AND CURNCYID=@CURNCYID AND UOFM LIKE @UOFM
)
INSERT @retTable
select itemnmbr,
isnull(max(case when PriceTable.[RowNumber] = 1 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break1
, max(case when PriceTable.[RowNumber] = 1 then
uomprice end) as Price1
, isnull(max(case when PriceTable.[RowNumber] = 2 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break2
, max(case when PriceTable.[RowNumber] = 2 then
uomprice end) as Price2
,isnull( max(case when PriceTable.[RowNumber] = 3 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break3
, max(case when PriceTable.[RowNumber] = 3 then
uomprice end) as Price3
,isnull( max(case when PriceTable.[RowNumber] = 4 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break4
, max(case when PriceTable.[RowNumber] = 4 then
uomprice end) as Price4
, isnull(max(case when PriceTable.[RowNumber] = 5 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break5
, max(case when PriceTable.[RowNumber] = 5 then
uomprice end) as Price5
, isnull(max(case when PriceTable.[RowNumber] = 6 then
LTRIM( STR(FROMQTY,6,0)) + '+' end),'') as Break6
, max(case when PriceTable.[RowNumber] = 6 then
uomprice end) as Price6
from PriceTable
group by itemnmbr, curncyid, prclevel, UOFM;

RETURN

END;
 

Putting it to work

Now it is a table valued function, this allows a crosstabbed price table to be used as if it were a table. For example to add in the item description from the item master table IV00101, the following is used;

 
SELECT 
IV00101.ITEMDESC,
PricesCrossTab.*
From Extract_PricesCrosstabTable('Z-US$','RETAIL','WIRE%','Foot') PricesCrossTab
JOIN IV00101
ON PricesCrossTab.ITEMNMBR= IV00101.ITEMNMBR

Results of join with IV00101 showing description pulled in

The unit of measure has been used as a parameter here for selection, however by changing the schema of the table valued function returned table type to include unit of measure as part of the primary key, all units of measure can be returned. This is the foundations of some scripts that can be amended to produce the results that you require for your particular circumstances.